Skip to content

Some quality of life API updates #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 20, 2024
Merged

Some quality of life API updates #116

merged 3 commits into from
Dec 20, 2024

Conversation

@MilesCranmer
Copy link
Member

@MilesCranmer MilesCranmer commented Dec 20, 2024

  1. allow nothing for variable_names. Will just default to "x$i"
  2. allow partial updates to metadata with
new_expr = with_metadata(expr; key=new_value)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024 •
edited
Loading

Benchmark Results

master e63317c... master/e63317c08806be...
eval/ComplexF32/evaluation 7.28 ± 0.63 ms 7.22 ± 0.57 ms 1.01
eval/ComplexF64/evaluation 10.8 ± 1.1 ms 10.7 ± 0.8 ms 1.01
eval/Float32/derivative 12.5 ± 1.8 ms 11.7 ± 0.91 ms 1.07
eval/Float32/derivative_turbo 12.6 ± 1.8 ms 11.9 ± 1.3 ms 1.06
eval/Float32/evaluation 2.75 ± 0.25 ms 2.71 ± 0.25 ms 1.01
eval/Float32/evaluation_bumper 0.613 ± 0.014 ms 0.602 ± 0.015 ms 1.02
eval/Float32/evaluation_turbo 0.578 ± 0.029 ms 0.536 ± 0.032 ms 1.08
eval/Float32/evaluation_turbo_bumper 0.614 ± 0.015 ms 0.599 ± 0.015 ms 1.02
eval/Float64/derivative 16 ± 0.95 ms 14.7 ± 0.58 ms 1.09
eval/Float64/derivative_turbo 15.6 ± 0.97 ms 14.7 ± 0.67 ms 1.07
eval/Float64/evaluation 3.2 ± 0.31 ms 3.12 ± 0.31 ms 1.03
eval/Float64/evaluation_bumper 1.27 ± 0.045 ms 1.26 ± 0.042 ms 1.01
eval/Float64/evaluation_turbo 1.1 ± 0.062 ms 1.03 ± 0.067 ms 1.08
eval/Float64/evaluation_turbo_bumper 1.27 ± 0.047 ms 1.26 ± 0.042 ms 1.01
utils/combine_operators/break_sharing 0.0383 ± 0.00062 ms 0.0391 ± 0.00058 ms 0.978
utils/convert/break_sharing 27.8 ± 2.3 μs 26.8 ± 2.1 μs 1.04
utils/convert/preserve_sharing 0.0999 ± 0.0043 ms 0.0974 ± 0.0042 ms 1.03
utils/copy/break_sharing 28.7 ± 2.4 μs 27.4 ± 2.1 μs 1.05
utils/copy/preserve_sharing 0.0998 ± 0.0039 ms 0.0992 ± 0.0042 ms 1.01
utils/count_constant_nodes/break_sharing 8.89 ± 0.19 μs 8.98 ± 0.21 μs 0.99
utils/count_constant_nodes/preserve_sharing 0.0862 ± 0.0032 ms 0.0875 ± 0.0039 ms 0.985
utils/count_depth/break_sharing 9.85 ± 0.26 μs 9.66 ± 0.27 μs 1.02
utils/count_nodes/break_sharing 8.48 ± 0.18 μs 8.32 ± 0.21 μs 1.02
utils/count_nodes/preserve_sharing 0.0874 ± 0.004 ms 0.0862 ± 0.0041 ms 1.01
utils/get_set_constants!/break_sharing 0.0343 ± 0.0021 ms 0.0337 ± 0.0022 ms 1.02
utils/get_set_constants!/preserve_sharing 0.176 ± 0.005 ms 0.176 ± 0.0057 ms 0.997
utils/get_set_constants_parametric 0.0444 ± 0.0022 ms 0.0442 ± 0.0025 ms 1
utils/has_constants/break_sharing 4.14 ± 0.18 μs 4.14 ± 0.12 μs 0.999
utils/has_operators/break_sharing 2.01 ± 0.11 μs 2.01 ± 0.068 μs 1
utils/hash/break_sharing 22.9 ± 0.89 μs 22.7 ± 0.62 μs 1.01
utils/hash/preserve_sharing 0.0973 ± 0.0028 ms 0.0971 ± 0.0036 ms 1
utils/index_constant_nodes/break_sharing 25.1 ± 0.87 μs 25.2 ± 1.1 μs 0.994
utils/index_constant_nodes/preserve_sharing 0.0996 ± 0.0036 ms 0.0998 ± 0.0044 ms 0.999
utils/is_constant/break_sharing 4.45 ± 0.16 μs 4.43 ± 0.13 μs 1
utils/simplify_tree/break_sharing 0.17 ± 0.0029 ms 0.167 ± 0.0033 ms 1.01
utils/simplify_tree/preserve_sharing 0.224 ± 0.0044 ms 0.221 ± 0.0063 ms 1.01
utils/string_tree/break_sharing 0.466 ± 0.015 ms 0.459 ± 0.018 ms 1.02
utils/string_tree/preserve_sharing 0.577 ± 0.02 ms 0.569 ± 0.026 ms 1.01
time_to_load 0.236 ± 0.0029 s 0.228 ± 0.00055 s 1.04

@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024

Pull Request Test Coverage Report for Build 12424756330

Details

  • 24 of 28 (85.71%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 95.55%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ParametricExpression.jl 5 7 71.43%
src/StructuredExpression.jl 4 6 66.67%
Totals Coverage Status
Change from base Build 12322890369: 0.02%
Covered Lines: 2555
Relevant Lines: 2674
💛 - Coveralls

@MilesCranmer MilesCranmer merged commit 97fc15b into master Dec 20, 2024
14 checks passed
@MilesCranmer MilesCranmer deleted the expression-qol-improvements branch December 20, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MilesCranmer